Fix flaky navigation editor test by waiting for required elements #34767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
|
Tests passing, so I'll go ahead and merge this and hopefully it resolves the issues in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While the test introduced in #34678 passed with no issues in the pull request, the test has been regularly failing in trunk since it was merged.
The e2e test artifacts didn't really shed any light on the issue. The screen shot shows the correct state, while the html shows an editor without any blocks.
I've added a few
waitForSelectorcalls just in case the html snapshot is correct, and it passed ok locally so hopefully this fixes things in CI too.