Save button: prevent focus loss #34731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
fix/save-focus-loss
branch
5 times, most recently
from
a25d9da to
df2b4c8
Compare
|
The snackbar is displaying and I believe the PR is working as intended, This is what I hear when I test the PR with NVDA screen reader and Chrome: |
ellatrix
force-pushed
the
fix/save-focus-loss
branch
from
df2b4c8 to
beb99f5
Compare
|
Going to merge this. Nothing crazy here. We're just adding a snackbar message for the save button for consistency and better accessibility. |
This was referenced Oct 12, 2021
priethor
added
the
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15529.
As recommended in #15529, #34539 already made the changes to keep the same save button through all its states to prevent focus loss, but we still need a spoken message. This can be done by adding a snackbar notice, which also speaks the message.
How has this been tested?
Save a post. Check the snackbar message.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).