Test env: turn debug on to catch dev errors and warnings #34730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
7 tasks
|
React 18 will remove warnings for "setState on unmounted component," but I think it would be nice to fix them just in case. |
ellatrix
force-pushed
the
try/test-with-debug
branch
from
aa7cfd3 to
e34e41b
Compare
|
Nice, that's good to know. Maybe they're fine to ignore them then and wait with this until we update React. There's still some other warnings though. |
|
If it's an easy fix like in #34618, we should probably go ahead and fix warnings. But if we have to resort to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A lot of useful errors and warnings are simply ignored by running tests with production code.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).