Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rest_is_field_included function in menu endpoints #34673

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Use rest_is_field_included function in menu endpoints #34673

merged 4 commits into from
Sep 14, 2021

Conversation

spacedmonkey
Copy link
Member

@spacedmonkey spacedmonkey commented Sep 8, 2021 •
edited
Loading

Description

Use rest_is_field_included function in menu endpoints.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@spacedmonkey spacedmonkey added Core REST API Task Task for Core REST API efforts REST API Interaction Related to REST API labels Sep 8, 2021
@spacedmonkey spacedmonkey self-assigned this Sep 8, 2021
TimothyBJacobs
TimothyBJacobs approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@TimothyBJacobs TimothyBJacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning that up!

@Mamaduka Mamaduka merged commit a721891 into trunk Sep 14, 2021
@Mamaduka Mamaduka deleted the fix/use-rest_is_field_included branch September 14, 2021 06:47
@github-actions github-actions bot added this to the Gutenberg 11.6 milestone Sep 14, 2021
@talldan talldan mentioned this pull request Sep 15, 2021
Merged
7 tasks
@spacedmonkey spacedmonkey mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyBJacobs TimothyBJacobs TimothyBJacobs approved these changes

@noisysocks noisysocks Awaiting requested review from noisysocks

@draganescu draganescu Awaiting requested review from draganescu

@adamziel adamziel Awaiting requested review from adamziel

Assignees

@spacedmonkey spacedmonkey

Labels
Core REST API Task Task for Core REST API efforts REST API Interaction Related to REST API
Projects
None yet
Milestone
Gutenberg 11.6
Development

Successfully merging this pull request may close these issues.
3 participants
@spacedmonkey @TimothyBJacobs @Mamaduka