Core Data: Adds 'include' to the query key #34583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Package] Core data
|
Size Change: +6 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
I think this also fixes #32594. I'm no longer able to reproduce the issue using the steps described here - #32594 (comment). But I think the issue with |
|
This looks good to me.
Do you mind clarifying a bit more here, I'm not sure what this refers to. Do you know why the "include" was excluded from the key initially (I guess maybe related to smart behavior we removed in the previous PR) |
|
Sorry for the confusion. Comment about I tracked down the original problem to the The But I think you're right. It was excluded because of the smart logic we removed in the previous PR. |
youknowriad
approved these changes
Sep 7, 2021
|
Thanks again for the review and feedback, @youknowriad
Agree. This is worth exploring. I'll what I can do in the near future. |
7 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
includeargument to the query key (stableKey). Trying to useitemIdsfrom the default stable key cache turned out to be problematic.TL;DR - Two requests with different include values cannot have the same results.
Details - #34034 (comment).
P.S. Should we consider a different "hashing" method for
stableKey. For example, querying withincludearray size of 100 would result in key something like this:Fixes #34506.
How has this been tested?
Unit tests should be passing.
Can be tested in browser console using following snippet
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).