[RNMobile][Embed block] Fix bottom sheet link color in dark mode #34424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyhun
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
|
Will go ahead and contribute a review from my side so Carlos can focus on other PRs for the embeds blocks 👍 |
hypest
added a commit
to wordpress-mobile/gutenberg-mobile
that referenced
this pull request
Sep 1, 2021
|
👋 @ceyhun! Using the installable build from this WPAndroid test PR, I see that the color is more bright than the "Before" case, but not the same as the "Add link" button (of the bottom sheet) you mention in the testing instructions. The new color is indeed better for dark mode, and light mode works perfect as well so, the PR looks great to me. Can you verify whether the "same as the Add link button" test should hold? Thanks!
|
hypest
approved these changes
Sep 1, 2021
There was a problem hiding this comment.
Changes look and work fine for me, so it's a LGTM for me! I've only left one comment asking about the test against the "Add link" button color.
Thanks @hypest! I added that case based on the example image in a comment shared by @iamthomasbishop (Internal reference p5T066-2Bq-p2#comment-9741). I thought they were the same, but now I checked and the "ADD LINK" button seems to be using the I've tried using
But this change might mean changing it in other place as well, like Audio Block's |
+1 for merging since this PR does fix the basic issue of the color being too dark for dark mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Embed block bottom sheet link color in dark mode
How has this been tested?
Learn more about embedsScreenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).