Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Author Block: add duotone suport #34408

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

MaggieCabrera
Copy link
Contributor

Description

This PR adds duotone support to the post author block

How has this been tested?

Using emptytheme

Screenshots

Editor

Screenshot 2021-08-31 at 10 54 22

Frontend

Screenshot 2021-08-31 at 10 54 28

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@MaggieCabrera MaggieCabrera self-assigned this Aug 31, 2021
@MaggieCabrera MaggieCabrera added the [Block] Post Author Affects the Post Author Block label Aug 31, 2021
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I see:

hey

And the filter as the code suggests applies only to the avatar image, and not the text or anything else:

Screenshot 2021-08-31 at 11 39 02

Seems good to me!

_Separately it looks like there's a lot of low hanging fruit we could pick with the post author block, but that's definitely separate.

@carolinan
Copy link
Contributor

I'd like to see a decision about the direction of the post author block before more features are added, to not make it more complicated if the block is split.
#24952

@ajlende
Copy link
Contributor

ajlende commented Aug 31, 2021

I'd like to see a decision about the direction of the post author block before more features are added, to not make it more complicated if the block is split. #24952

@carolinan Do you think #24952 will be resolved soon? Since this only adds a single line to the block.json, it doesn't seem to me like there's very much complexity added, and people who are already using the post author block could benefit from this feature now.

Copy link
Contributor

@ajlende ajlende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to press the Approve button yesterday 😅 But the change works well for me!

With the featured image and now this, on some pages, there are starting to be a lot of generated SVGs. It's something that I'll look into, and maybe it can be included with the theme.json work in #34073.

@carolinan
Copy link
Contributor

@carolinan Do you think #24952 will be resolved soon?

Only if people engage in the conversations so that it can be resolved. Basically someone needs to make a decision.

@MaggieCabrera MaggieCabrera merged commit 866af4f into trunk Sep 2, 2021
@MaggieCabrera MaggieCabrera deleted the add/duotone-post-author branch September 2, 2021 13:44
@github-actions github-actions bot added this to the Gutenberg 11.5 milestone Sep 2, 2021
@getsource getsource added [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement. labels Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Author Affects the Post Author Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants