-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Author Block: add duotone suport #34408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a decision about the direction of the post author block before more features are added, to not make it more complicated if the block is split. |
@carolinan Do you think #24952 will be resolved soon? Since this only adds a single line to the block.json, it doesn't seem to me like there's very much complexity added, and people who are already using the post author block could benefit from this feature now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to press the Approve button yesterday 😅 But the change works well for me!
With the featured image and now this, on some pages, there are starting to be a lot of generated SVGs. It's something that I'll look into, and maybe it can be included with the theme.json work in #34073.
Only if people engage in the conversations so that it can be resolved. Basically someone needs to make a decision. |
a798f6c
to
0e13c61
Compare
Description
This PR adds duotone support to the post author block
How has this been tested?
Using emptytheme
Screenshots
Editor
Frontend
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.js
files for terms that need renaming or removal).