Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image caption colour for better accessibility #3439

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Update image caption colour for better accessibility #3439

merged 1 commit into from
Nov 13, 2017

Conversation

samikeijonen
Copy link
Contributor

@samikeijonen samikeijonen commented Nov 11, 2017 •
edited
Loading

Description

Use colour #6c7781 for image captions so that it meets colour contrast 4.5:1 guideline.

See issue #2899.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@youknowriad youknowriad added the Needs Design Feedback Needs general design feedback. label Nov 13, 2017
@karmatosed
Copy link
Member

karmatosed commented Nov 13, 2017 •
edited
Loading

@samikeijonen looks good to me and checks against: https://codepen.io/hugobaeta/full/RNOzoV/

@karmatosed karmatosed merged commit 3408aa6 into WordPress:master Nov 13, 2017
@samikeijonen samikeijonen deleted the update/image branch November 14, 2017 06:47
@mtias
Copy link
Member

mtias commented Nov 14, 2017

Should this be applied to embeds?

@samikeijonen
Copy link
Contributor Author

Yes, for everything that has that original color value. I can do it in separate PR.

Color #6c7781 works for white backgrounds but we naturally have other backgrounds also. So there is no 100% bullet proof color.

@samikeijonen samikeijonen mentioned this pull request Nov 14, 2017
Merged
@samikeijonen samikeijonen mentioned this pull request Feb 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samikeijonen @karmatosed @mtias @youknowriad