-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate post editor feature preferences to the interface package #34154
Merged
talldan
merged 4 commits into
trunk
from
migrate/post-editor-feature-preferences-to-interface-package
Aug 23, 2021
Merged
Migrate post editor feature preferences to the interface package #34154
talldan
merged 4 commits into
trunk
from
migrate/post-editor-feature-preferences-to-interface-package
Aug 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
A suggestion for improvement.
[Package] Edit Post
/packages/edit-post
labels
Aug 19, 2021
18 tasks
Size Change: +127 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
7 tasks
talldan
force-pushed
the
migrate/post-editor-feature-preferences-to-interface-package
branch
from
August 20, 2021 09:05
ccf602c
to
82d0bb0
Compare
7 tasks
kevin940726
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
talldan
deleted the
migrate/post-editor-feature-preferences-to-interface-package
branch
August 23, 2021 08:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partly addresses #31965. Related to #31965 and #34135.
Migrates post editor feature preferences over to the interface package.
Here there was a choice of deprecating the post editor's APIs for features, but this keeps them as backwards compatibility is pretty easy to maintain. Any selectors and actions call through to the interface store's implementation.
How has this been tested?
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.js
files for terms that need renaming or removal).