[Mobile] - Autocomplete - Show icons for embed suggestions #34117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
the
Mobile App - i.e. Android or iOS
2 tasks
|
Size Change: +1.3 kB (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
|
I'm wondering if the embed variants should be included in the autocomplete because they're not present in the block picker 🤔. We actually have a pending task for enabling them but it hasn't been tackled yet. |
Interesting, is there a reason why we wouldn't want them there? Looking at that issue, it mentions to enable the top 8 most used ones, do you think that limit should exist as well in the slash inserter feature? Regardless of the decision, this issue still stands since these icons are not showing up 😅 |
That's a good question, as far as I know, this topic hasn't been considered in the project so I'm going to expose it and open an issue as a follow-up. From my POV, I think it makes sense that they exist there, I think the main reason for only showing the most used ones in the block picker is a matter of highlighting them, which wouldn't be the same case in the slash inserter.
True 😅 , I'll review it as soon as possible to be included in the next release 💨 . |
fluiddot
reviewed
Aug 18, 2021
packages/components/src/autocomplete/autocompleter-ui.native.js
Outdated
Show resolved
Hide resolved
fluiddot
approved these changes
Aug 18, 2021
|
@geriux let me know when you create the Gutenberg Mobile PR to review it too, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#3845Description
This PR fixes an issue where the slash inserter feature (autocomplete) is not showing some icons to the suggestions (for embeds).
How has this been tested?
/into a Paragraph blockVideoPress,CloudUp,CrowdsignalScreenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).