Remove a popover menu min-width. #33995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Type] Code Quality
7 tasks
|
Size Change: -1.67 kB (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
|
Thanks for the review. I gave it a good extra spin to see that popovers were behaving:
I found one that was misbehaving:
So I pushed a small tweak:
@draganescu I see your name in the context of that code, can you give c69e72b a quick sanity check? Thank you. After that, I'd love to land this as it unblocks a vertical headings PR. |
|
Going to land this one, as the min-width is arbitrary, and the component becomes more flexible without it. |
This was referenced Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a min-width from the dropdown component. The min-width is meant to ensure that items inside don't collapse or become as small as possible by leveraging word wrapping, which is what happens if we only remove the min-width:
For that reason, I've also added a whitespace rule that ensures that menu items never wrap, as they arguably shouldn't ever do:
It would have been easy to add just the whitespace rule to the particular "open in new window" element. However in a desire to keep the behavior of the child item the responsibility of the parent, this PR puts the CSS directly in the dropdown component.
What do you think?
The PR itself will also benefit #32926.
How has this been tested?
Please test every dropdown that opens a popover menu, and verify none of them look squished.
Checklist:
*.native.jsfiles for terms that need renaming or removal).