Try to fix flaky customizer inspector test 2nd try #33965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Feature] Widgets Customizer
7 tasks
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
|
Thanks for the quick follow-up, @kevin940726. Maybe we should use almost 0s values in the "disable-css-animations" plugin? Using "0s" looks like to be a problematic solution. Here's a good discussion about the alternative approaches - jensimmons/cssremedy#11. This is distilled example based on that discussion: @media (prefers-reduced-motion: reduce) {
*, *::after, *::before {
animation-duration: 1ms !important; /* 1 */
animation-delay: -1ms !important; /* 2 */
animation-iteration-count: 1 !important; /* 3 */
transition-duration: 1ms !important; /* 4 */
transition-delay: -1ms !important; /* 5 */
}
}Source: https://www.inovex.de/de/blog/removing-animations-people-troubled-motion-css-angular/ |
|
Yep Fixing it in the test plugin just hides the problems away. Instead, I would like to deprecate the test plugin in the long term and disable all transitions/animations in our code if |
|
I agree it's not an ideal solution, but it might be a good temporary solution. Customizer ticket has WP 5.9 milestone. Unfortunately, I'm not familiar with that part of the code nor with Backbone.js enough to fix the issue. Let's re-run e2e tests here a few times, and then we can merge PR if everything is green. |
Mamaduka
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
@kevin940726 I re-run e2e test 3 times + initial run. No failures 🎉
Let's merge this and continue monitoring on trunk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continue from #33890. Second try to fix flaky e2e tests.
#33890 had the right call, but the fix didn't work. This PR instead try to disable the intermediate transition to prevent the block toolbar from moving to the wrong position. Hopefully this time it'll fix it.
How has this been tested?
Not yet found a reliable way to reproduce the issue, so maybe we just have to merge this and monitor it on trunk.
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).