Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer read from experimental-theme.json #33904

Merged
merged 2 commits into from
Aug 9, 2021

Conversation

oandregal
Copy link
Member

We used experimental-theme.json as a name for the file that holds the settings & styles while it was experimental. When the feature was stabilized the file was renamed to theme.json but we also kept a fallback to the previous name in the plugin, so themes had some time to rename it. We can get rid of this fallback now that WordPress 5.8 is released and bundles theme.json by default.

@oandregal oandregal requested a review from spacedmonkey as a code owner August 5, 2021 15:18
@oandregal oandregal self-assigned this Aug 5, 2021
@oandregal oandregal requested a review from a team August 5, 2021 15:18
@oandregal oandregal added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Aug 5, 2021
@oandregal oandregal requested a review from aristath August 5, 2021 15:18
@oandregal oandregal changed the title Remove no longer necessary fallback No longer read from experimental-theme.json Aug 5, 2021
@Mamaduka
Copy link
Member

Mamaduka commented Aug 5, 2021

This is probably a task for separated PR. But should we also rename experimental-default-theme.json, that we ship with the plugin, to default-theme.json or theme.json?

@oandregal
Copy link
Member Author

@Mamaduka it makes sense to me, also for the i18n file. Prepared it at #33925

@oandregal oandregal requested a review from Mamaduka August 6, 2021 10:55
@oandregal oandregal added the [Type] Code Quality Issues or PRs that relate to code quality label Aug 6, 2021
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I don't think we need deprecation here since this was an experimental structure/file.

@oandregal oandregal force-pushed the remove/experimental-theme-json-fallback branch from 112e35c to 4d1bdb3 Compare August 9, 2021 09:17
@oandregal oandregal merged commit 5acde95 into trunk Aug 9, 2021
@oandregal oandregal deleted the remove/experimental-theme-json-fallback branch August 9, 2021 10:13
@github-actions github-actions bot added this to the Gutenberg 11.3 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants