Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken link in documentation to block support mechanism #33780

Merged
merged 2 commits into from
Aug 4, 2021
Merged

fix: broken link in documentation to block support mechanism #33780

merged 2 commits into from
Aug 4, 2021

Conversation

RhnSharma
Copy link
Contributor

Description

Fixes #33778
Fix a broken link to block support mechanism in theme-json.md.

Hi @Mamaduka, how does this look?
Let me know if this needs any changes.
Thanks

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Jul 30, 2021
@Mamaduka Mamaduka added the [Type] Bug An existing feature does not function as intended label Aug 2, 2021
Mamaduka
Mamaduka approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @RhnSharma

Changes look good to me 👍

@ntsekouras ntsekouras merged commit 97f8afc into WordPress:trunk Aug 4, 2021
@github-actions github-actions bot added this to the Gutenberg 11.3 milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 11.3
4 participants
@RhnSharma @Mamaduka @skorasaurus @ntsekouras