-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regressed menu selection dropdown placeholder value for Nav Editor menu locations UI #33748
Merged
getdave
merged 1 commit into
trunk
from
update/use-clearer-default-option-for-menu-selection-dropdown
Jul 29, 2021
Merged
Fix regressed menu selection dropdown placeholder value for Nav Editor menu locations UI #33748
getdave
merged 1 commit into
trunk
from
update/use-clearer-default-option-for-menu-selection-dropdown
Jul 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
An existing feature does not function as intended
[Feature] Navigation Screen
labels
Jul 29, 2021
getdave
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks and
tellthemachines
as code owners
July 29, 2021 10:06
Closed
getdave
added
[Package] Edit Navigation
[Type] Regression
Related to a regression in the latest release
and removed
[Type] Bug
An existing feature does not function as intended
labels
Jul 29, 2021
Size Change: +3 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
kevin940726
approved these changes
Jul 29, 2021
Mamaduka
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Dave.
Changes look good 👍
getdave
deleted the
update/use-clearer-default-option-for-menu-selection-dropdown
branch
July 29, 2021 11:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Takes over from #32423 (comment) as the contributor seems unable to continue.
Closes #30330
How has this been tested?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.js
files for terms that need renaming or removal).