Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of LinkURL menu and fix spacing. #33652

Merged
merged 5 commits into from
Jul 30, 2021
Merged

Improve display of LinkURL menu and fix spacing. #33652

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87138f5
Improve display of LinkURL menu and fix spacing.
mtias Jul 23, 2021
09c3890
Fix rendering of site icon in link preview.
mtias Jul 23, 2021
451700c
Adjust image icon size.
mtias Jul 23, 2021
37a2209
Adjust placeholder flash for icon element.
mtias Jul 30, 2021
5713f0d
Add comment about favicon sizes.
mtias Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/block-editor/src/components/link-control/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,13 +184,11 @@ $preview-image-height: 140px;
position: relative;
top: 0.2em;
margin-right: $grid-unit-10;
width: 18px; // half of 32px to improve perceived resolution.
height: 18px; // half of 32px to improve perceived resolution.
max-height: 24px;
flex-shrink: 0;

svg,
img {
max-width: none;
width: 18px; // half of 32px to improve perceived resolution.
width: 16px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
width: 16px;
width: 16px; // downscale image x2 improve perceived resolution of smaller favicons.

Nit: I'd like to restore this to make it explicit as to what we are doing and why.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tried getting larger icons through the apple-touch-icon property instead of going straight to favicon?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is on the roadmap...but you cannpt guarantee it. Therefore we still need these aa defaults for now.

}
}

Expand Down Expand Up @@ -385,7 +383,7 @@ $preview-image-height: 140px;
align-items: center;
border-top: $border-width solid $gray-300;
margin: 0;
padding: $grid-unit-20 $grid-unit-30;
padding: $grid-unit-20;
}

.block-editor-link-control__unlink {
Expand Down