Query Block Post Template: Update empty state messaging (WIP) #33523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyip
added
[Feature] Full Site Editing
[Block] Query Loop
jeyip
added
the
[Priority] Low
|
Size Change: +36 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jul 19, 2021
There was a problem hiding this comment.
👋 - thanks for working on this. This message though can be misleading as the case for no results is either having no posts or having set some filters with no matches. Also we can have other post types selected`.
I haven't thought about it much yet but maybe a new no results block could be added and be shown in front-end as well? 🤔
This would need some UX consideration as well, since we would need to be able to edit this block even if we have results from the current query.
Ahhh that makes sense. I'm not as experienced with the Query Loop Block though. Would a visitor to the site be setting the filters when they're playing around on the blog and exploring posts, or would it be the blog creator setting the filters while they're customizing their site? Would you also mind giving an example of where a filter could be set?
Interesting idea! Especially if it allows the user to customize the |
Yes. The controls in the sidebar Inspector controls are in post-editor.
I guess its usage will be per user needs. Someone would want to make a small |
7 tasks
annezazu
added
[Feature] Site Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Potentially addresses #32606
How has this been tested?
Screenshots
Types of changes
Feature work (improving UX)
Todos
Checklist:
*.native.jsfiles for terms that need renaming or removal).