Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'wp/' namespace to 'core/' #332

Merged
merged 1 commit into from
Mar 27, 2017
Merged

Change 'wp/' namespace to 'core/' #332

merged 1 commit into from
Mar 27, 2017

Conversation

nylen
Copy link
Member

@nylen nylen commented Mar 27, 2017

This PR changes the namespace for built-in blocks from wp/ to core/. I think the delimiter tags look nicer this way:

- <!-- wp:wp/text -->
+ <!-- wp:core/text ->

youknowriad
youknowriad approved these changes Mar 27, 2017
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 The wp:wp was a bit weird

@nylen nylen merged commit 8e62d60 into master Mar 27, 2017
@nylen nylen deleted the update/rename-core-namespace branch March 27, 2017 16:03
nylen added a commit to BE-Webdesign/gutenberg that referenced this pull request Mar 27, 2017
@nylen
Change 'wp/' to 'core/' (see WordPress#332)
5bd11bd
@nylen nylen mentioned this pull request Mar 27, 2017
Closed
@nylen nylen mentioned this pull request Mar 27, 2017
Closed
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Nov 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nylen @youknowriad