Fix legacy widget height overflow #33191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
kevin940726
requested review from
draganescu,
adamziel,
getdave,
noisysocks,
talldan and
tellthemachines
|
Size Change: +50 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
|
I'm still seeing scrollbars on the Gallery widget, is there anything that can be done to resolve that? Though it does also have a horizontal scrollbar, so maybe that's causing issues. |
talldan
reviewed
Jul 5, 2021
noisysocks
added
the
Backport to WP 6.7 Beta/RC
talldan
reviewed
Jul 5, 2021
kevin940726
force-pushed
the
fix/legacy-widget-height
branch
from
4b044af to
07d3cf0
Compare
talldan
approved these changes
Jul 5, 2021
There was a problem hiding this comment.
I couldn't spot any issues in testing and code looks good too, thanks @kevin940726!
youknowriad
pushed a commit
that referenced
this pull request
Jul 5, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 6, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #33115. Fix #33123.
Fix legacy widget height overflow. I also refactored the code a bit to make it simpler.
The margins are a bit high, Most of them are coming from the preview. We'll need to add some custom styling in the preview frame to remove the margins. It probably will have to be done in core though.
Please note that I don't think this is the optimal solution. I believe we should migrate away from iframes in the future, so probably don't worth much time trying to fix every edge case here.
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).