E2E Tests: Add coverage for reusable blocks save button state regression #33151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Feature] Synced Patterns
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
WunderBart
reviewed
Jul 5, 2021
packages/e2e-tests/specs/editor/various/reusable-blocks.test.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Jul 9, 2021
|
|
||
| await publishPost(); | ||
|
|
||
| // Close publish panel. |
There was a problem hiding this comment.
should this part of the publishPost utility?
There was a problem hiding this comment.
We have some tests that click the publish panel's "View Post" link right after publishing, so we'd have to modify those. If it's okay, I'd thus leave publishPost untouched for now, in order to get this PR in without further detours :)
youknowriad
reviewed
Jul 9, 2021
ockham
force-pushed
the
add/e2e-test-coverage-for-reusable-block-save-button
branch
from
275ca1c to
34398d4
Compare
e2e tests seem to pass after a rebase. I'll try to pick this up and get it ready for another round of review. |
|
Hmm, I can't seem to get the test to fail anymore, even when reverting the relevant changes from 127cc57 😅 |
ntsekouras
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
Hmm, I can't seem to get the test to fail anymore, even when reverting the relevant changes from 127cc57 😅
I guess it's because you had made another proper fix after the revert 😄
In order to make the test fail you need to make the change you were looking in the revert PR and also revert the changes you made in the fix afterwards here - that code wasn't there at the time of the regression and the revert.
I'll approve this as I could make it fail with the above but I'd like an extra sanity check Bernie 😄. Thanks!
Hah, of course! 🤦♂️ Thanks, I didn't see the forest for the trees 😅 Let the record show that reverting a6908dc and then 127cc57 (and then rebuilding Gutenberg) does indeed cause the test to fail 🥳
Thanks a lot! I'll go ahead and merge 🎉 |
ockham
deleted the
add/e2e-test-coverage-for-reusable-block-save-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds E2E test coverage for #33072.
How has this been tested?
Verify that e2e tests pass for this branch (CI or locally).
Check the branch out locally, revert
127cc57641caacc7187608edf3e2b11382e70f84, and rebuild Gutenberg. Verify that the newly added e2e test now fails.