[DO NOT MERGE] Debug stale useSelect value #33081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `isPostTitleSelected` value appears to update _within_ `useSelect`, but the return value appears stale.
dcalhoun
added
[Status] Needs More Info
|
Size Change: +56 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
|
Closed in favor of #38509. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is further debugging of #32154. A fix was applied in #32831, but it shouldn't be necessary as the dependency array should only memoize
mapSelectitself, not the return value ofuseSelect. I have been unable to identify what is causing the stale value fromuseSelect.The
isPostTitleSelectedvalue appears to update withinuseSelect, but the return value appears stale. WhenmapSelecthas not changed, the update state is assigned tolatestMapOutput.current, but that value is not returned in the nextforceRender. A stale value appears to be returned fromuseSelect.Changing
forceRender()tosetTimeout(forceRender, 0)fixes the issue, showcasing the value is temporarily stale.How has this been tested?
This PR is for debugging purposes and has not been tested.
Screenshots
use-select-stale-value.mov
Types of changes
Temporary debugging PR.
Checklist:
*.native.jsfiles for terms that need renaming or removal).