[Block Library - Post Terms]: Fix handling for low privileged users #32947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
ockham,
mcsf,
youknowriad,
aristath,
gziolo and
Copons
ntsekouras
added
[Block] Post Terms
|
Size Change: +17 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
fix/post-terms-view-context
branch
from
8994989
to
7305431
Compare
youknowriad
reviewed
Jun 24, 2021
ntsekouras
force-pushed
the
fix/post-terms-view-context
branch
from
d444b21
to
a8c08ef
Compare
youknowriad
approved these changes
Jun 25, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 25, 2021
…32947) * [Block Library - Post Terms]: Fix handling for low privileged users * use `apiFetch` * revert changes that have been applied to trunk * revert to use context 'view'
youknowriad
pushed a commit
that referenced
this pull request
Jun 25, 2021
…32947) * [Block Library - Post Terms]: Fix handling for low privileged users * use `apiFetch` * revert changes that have been applied to trunk * revert to use context 'view'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of: #26573
Currently when a user with no right permissions to edit
termshas a broken experience withPost Termsblocks (Post Tags, Post Categories) due to the permissions check happening at the REST API.This PR fixes that by changing the fetching of the terms with
context:view. This block doesn't update any term so it purelyreadonly.Testing instructions
Post Tags, Post Categoriesand observe that everything works as before.Post Inspector controls(sidebar).Notes
useTermLinks->usePostTerms).Checklist:
*.native.jsfiles for terms that need renaming or removal).