Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget preivew not working if widget registered via a instance #32781

Merged
merged 6 commits into from
Jun 22, 2021
Merged

Widget preivew not working if widget registered via a instance #32781

merged 6 commits into from
Jun 22, 2021

Conversation

spacedmonkey
Copy link
Member

Description

Details on this ticket can be found here - https://core.trac.wordpress.org/ticket/53427

This ticket introduces a new filter called wp_get_legacy_widget_key which means that we do not have hardcode references to gutenberg_get_widget_object into core.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@spacedmonkey spacedmonkey self-assigned this Jun 17, 2021
@spacedmonkey spacedmonkey added [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Package] Edit Widgets /packages/edit-widgets labels Jun 17, 2021
@spacedmonkey spacedmonkey mentioned this pull request Jun 18, 2021
Closed
53 tasks
noisysocks
noisysocks approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that previewing a Legacy Widget works when running plugin against trunk and 5.7. LGTM 👍

packages/widgets/src/blocks/legacy-widget/index.php Outdated Show resolved Hide resolved
@noisysocks noisysocks added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 21, 2021
@spacedmonkey spacedmonkey requested a review from noisysocks June 21, 2021 14:53
@adamziel
Copy link
Contributor

The failure looks unrelated, I just restarted the job.

@noisysocks noisysocks merged commit ef339e3 into WordPress:trunk Jun 22, 2021
@github-actions github-actions bot added this to the Gutenberg 11.0 milestone Jun 22, 2021
@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 22, 2021
noisysocks pushed a commit that referenced this pull request Jun 22, 2021
@spacedmonkey @noisysocks
Widget preivew not working if widget registered via a instance (#32781)
75120de
@noisysocks noisysocks mentioned this pull request Jun 22, 2021
Merged
jorgefilipecosta pushed a commit that referenced this pull request Jun 22, 2021
@spacedmonkey @jorgefilipecosta
Widget preivew not working if widget registered via a instance (#32781)
55e1f89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@noisysocks noisysocks Awaiting requested review from noisysocks

Assignees

@spacedmonkey spacedmonkey

Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Package] Edit Widgets /packages/edit-widgets
Projects
None yet
Milestone
Gutenberg 11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@spacedmonkey @adamziel @noisysocks