Card: update Storybook story #32763
Merged
Card: update Storybook story #32763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Package] Components
This was referenced Jun 17, 2021
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
ciampo
force-pushed
the
feat/components-card-promote
branch
from
5705bfc to
6c2cbd9
Compare
ciampo
force-pushed
the
feat/components-card-update-stories
branch
from
5d0b818 to
203bcf8
Compare
ciampo
force-pushed
the
feat/components-card-promote
branch
from
6c2cbd9 to
5bd2875
Compare
ciampo
force-pushed
the
feat/components-card-update-stories
branch
from
203bcf8 to
d43e314
Compare
ciampo
requested review from
tyxla and
sarayourfriend
and removed request for
tyxla and
sarayourfriend
sarayourfriend
approved these changes
Jun 22, 2021
ciampo
force-pushed
the
feat/components-card-update-stories
branch
from
d43e314 to
d8af470
Compare
ciampo
force-pushed
the
feat/components-card-update-stories
branch
from
d8af470 to
cd94c10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of a series of PRs with the final goal of achieving the same result as #32243 in smaller (and easier to review) steps.
Requires #32566 to be merged first.
Rewrite storybook stories for the
<Card />component. Previously, there were many, small stories that were showing each subcomponent in isolation, without any knobs. This approach didn't really show how to use the<Card />and its subcomponents in a real scenario.The new story renders all of the components in one example and introduces many interactive controls (knobs).
Testing instructions
npm run storybook:devand visithttp://localhost:50240/?path=/story/components-card--defaultScreenshots
Types of changes
New feature (new story)
Checklist:
*.native.jsfiles for terms that need renaming or removal).