Fix Post Content block regression #32693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
ntsekouras
approved these changes
Jun 15, 2021
aristath
approved these changes
Jun 15, 2021
|
Size Change: -2 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
looks like the performance test is still failing, not sure if there's something else going on here. |
youknowriad
commented
Jun 15, 2021
| @@ -189,6 +189,7 @@ function* loadPostTypeEntities() { | |||
| record?.title || | |||
| ( isTemplate ? startCase( record.slug ) : String( record.id ) ), | |||
| __unstablePrePersist: isTemplate ? undefined : prePersistPostType, | |||
| __unstable_rest_base: postType.rest_base, | |||
There was a problem hiding this comment.
Ideally this should be something that is available in all entities (and not just post one) but also ideally, it could potentially be better though, basically we need this properly to match with the "permissions" array, we could have a canEdit function per entity or a getResource or something like that. But this will do for now.
|
I expect the performance test to still fail in this PR because it compares against trunk which is broken now, so I'll force merge this one. |
youknowriad
added a commit
that referenced
this pull request
Jun 15, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block has been refactored recently but it looks like the context values where not consumed properly when the block is editable.