Move Legacy Widget block to @wordpress/widgets #32501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
the
[Block] Legacy Widget
noisysocks
added
the
Backport to WP 6.7 Beta/RC
noisysocks
changed the title
|
I see when running
It has a huge impact on the number of resources that need to be processed by the browser on the edit post page: Before:Total 7.5 MB.
After:Total 6.1 MB.
That's another reason to include the Legacy Widget block only in the widgets editor. |
|
Yeah, I've been on the fence about this decision but reducing post editor bundle size is the most compelling reason I think to keep the block exclusively in the widgets screen. At least until we have a nice story around lazy loading block resources :) I'll finish work on this PR and we can get it into 5.8 beta 2. |
noisysocks
force-pushed
the
update/move-legacy-widget-block-to-widgets-package
branch
from
747ff4f to
cca4864
Compare
|
Size Change: -871 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
noisysocks
force-pushed
the
update/move-legacy-widget-block-to-widgets-package
branch
from
cca4864 to
d00edda
Compare
noisysocks
commented
Jun 9, 2021
| if ( 20 === has_action( 'init', 'register_block_core_legacy_widget' ) ) { | ||
| remove_action( 'init', 'register_block_core_legacy_widget', 20 ); | ||
| add_action( 'init', 'register_block_core_legacy_widget', 10 ); | ||
| } |
There was a problem hiding this comment.
This isn't strictly related to this PR but noticed it can be removed now because #32300 has been published to core.
noisysocks
commented
Jun 9, 2021
| @@ -1,3 +1,3 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|
|||
| exports[`WP Editor Meta Boxes Should save the changes 1`] = `"<p>Typing in a metabox</p>"`; | |||
| exports[`WP Editor Meta Boxes Should save the changes 1`] = `"Typing in a metabox"`; | |||
There was a problem hiding this comment.
One of the scripts enqueued in widgets.php (which, until this PR, we were loading alongside every block editor) caused TinyMCE to wrap paragraphs with <p>. I don't know what it is. I don't think there are any repercussions beyond this test fixture needing to change, but it would be good to double check with some experts AKA @youknowriad and @azaozz.
There was a problem hiding this comment.
Funny I had the same diff when running the e2e tests against Core a couple weeks ago. Basically in core, I didn't have the ps either.
There was a problem hiding this comment.
Aha, that makes sense as Core never was loading widgets.php scripts into the block editor which is what the plugin does.
There was a problem hiding this comment.
Hi, folks
I had to revert this change in #32915.
There was a problem hiding this comment.
It looks like after 5.8 beta 3, the wrapping <p> is back!
noisysocks
force-pushed
the
update/move-legacy-widget-block-to-widgets-package
branch
from
e82f65c to
2aa3145
Compare
noisysocks
requested review from
adamziel,
ajitbohra,
chrisvanpatten,
draganescu,
kevin940726,
nerrad,
ntwb,
spacedmonkey and
talldan
as code owners
noisysocks
requested review from
tellthemachines and
TimothyBJacobs
as code owners
noisysocks
changed the title
|
OK I've tested this against WordPress trunk and WordPress 5.7 and all seems good. Ready for review/merge. |
|
Does it also mean that |
|
Yes that's right. Both Widgets and the Customizer need it though so we'll have to find some new place to put that. I shall handle that in the Core package update PR when it's time. |
noisysocks
deleted the
update/move-legacy-widget-block-to-widgets-package
branch
|
@youknowriad: Back-porting this one to Core will be a little bit weird. Ping me when you have a Notes for myself when I do that:
|
|
@noisysocks Thanks for the headsup, in general I do the backports each Monday, so we can probably do it Monday early if you're still around or I can start the work on Monday and leave the PR there for you for Tuesday. |
|
Thank you @noisysocks for landing this one. It should improve the loading time for the post editor ❤️ We should also seek more optimizations like moving the Classic block outside of the |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 14, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 14, 2021
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Jun 15, 2021
…ta 2. This includes: **Various** - Fix multi selection for nested blocks WordPress/gutenberg#32536 - Consistently show the drop indicator while dragging blocks WordPress/gutenberg#31896 - Fix horizontal drop indicator WordPress/gutenberg#32589 - Fix Safari flickering issue WordPress/gutenberg#32581 - Silence useSelect zombie bug errors WordPress/gutenberg#32088 **Template Editor** - Clarify the template creation modal WordPress/gutenberg#32427 - Only add skip links for block templates WordPress/gutenberg#32451 **Widgets Editor** - Add block breadcrumb WordPress/gutenberg#32498 WordPress/gutenberg#32528 WordPress/gutenberg#32569 - Saved deleted and restored widgets. WordPress/gutenberg#32534 - Fix unsaved changes detection WordPress/gutenberg#32573 - Fix button spacing in the header WordPress/gutenberg#32585 - Avoid extra undo levels WordPress/gutenberg#32572 - Move Legacy Widget block to the `@wordpress/widgets` package WordPress/gutenberg#32501 - Fix Social Links color inheritance WordPress/gutenberg#32625 - Use Button appender WordPress/gutenberg#32580 **Global Styles (theme.json)** - Separate the presets per origin in the block editor settings WordPress/gutenberg#32358 WordPress/gutenberg#32622 - Use CSS Custom Properties for the preset styles WordPress/gutenberg#32627 **Performance** - Remove is-typing classname to improve typing performance WordPress/gutenberg#32567 Props nosolosw, jorgefilipecosta, aristath, ntsekouras, peterwilsoncc, mcsf. See #53397. git-svn-id: https://develop.svn.wordpress.org/trunk@51149 602fd350-edb4-49c9-b593-d223f7449a82
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Jun 15, 2021
…ta 2. This includes: **Various** - Fix multi selection for nested blocks WordPress/gutenberg#32536 - Consistently show the drop indicator while dragging blocks WordPress/gutenberg#31896 - Fix horizontal drop indicator WordPress/gutenberg#32589 - Fix Safari flickering issue WordPress/gutenberg#32581 - Silence useSelect zombie bug errors WordPress/gutenberg#32088 **Template Editor** - Clarify the template creation modal WordPress/gutenberg#32427 - Only add skip links for block templates WordPress/gutenberg#32451 **Widgets Editor** - Add block breadcrumb WordPress/gutenberg#32498 WordPress/gutenberg#32528 WordPress/gutenberg#32569 - Saved deleted and restored widgets. WordPress/gutenberg#32534 - Fix unsaved changes detection WordPress/gutenberg#32573 - Fix button spacing in the header WordPress/gutenberg#32585 - Avoid extra undo levels WordPress/gutenberg#32572 - Move Legacy Widget block to the `@wordpress/widgets` package WordPress/gutenberg#32501 - Fix Social Links color inheritance WordPress/gutenberg#32625 - Use Button appender WordPress/gutenberg#32580 **Global Styles (theme.json)** - Separate the presets per origin in the block editor settings WordPress/gutenberg#32358 WordPress/gutenberg#32622 - Use CSS Custom Properties for the preset styles WordPress/gutenberg#32627 **Performance** - Remove is-typing classname to improve typing performance WordPress/gutenberg#32567 Props nosolosw, jorgefilipecosta, aristath, ntsekouras, peterwilsoncc, mcsf. See #53397. git-svn-id: https://develop.svn.wordpress.org/trunk@51149 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jun 15, 2021
…ta 2. This includes: **Various** - Fix multi selection for nested blocks WordPress/gutenberg#32536 - Consistently show the drop indicator while dragging blocks WordPress/gutenberg#31896 - Fix horizontal drop indicator WordPress/gutenberg#32589 - Fix Safari flickering issue WordPress/gutenberg#32581 - Silence useSelect zombie bug errors WordPress/gutenberg#32088 **Template Editor** - Clarify the template creation modal WordPress/gutenberg#32427 - Only add skip links for block templates WordPress/gutenberg#32451 **Widgets Editor** - Add block breadcrumb WordPress/gutenberg#32498 WordPress/gutenberg#32528 WordPress/gutenberg#32569 - Saved deleted and restored widgets. WordPress/gutenberg#32534 - Fix unsaved changes detection WordPress/gutenberg#32573 - Fix button spacing in the header WordPress/gutenberg#32585 - Avoid extra undo levels WordPress/gutenberg#32572 - Move Legacy Widget block to the `@wordpress/widgets` package WordPress/gutenberg#32501 - Fix Social Links color inheritance WordPress/gutenberg#32625 - Use Button appender WordPress/gutenberg#32580 **Global Styles (theme.json)** - Separate the presets per origin in the block editor settings WordPress/gutenberg#32358 WordPress/gutenberg#32622 - Use CSS Custom Properties for the preset styles WordPress/gutenberg#32627 **Performance** - Remove is-typing classname to improve typing performance WordPress/gutenberg#32567 Props nosolosw, jorgefilipecosta, aristath, ntsekouras, peterwilsoncc, mcsf. See #53397. Built from https://develop.svn.wordpress.org/trunk@51149 git-svn-id: http://core.svn.wordpress.org/trunk@50758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Jun 15, 2021
…ta 2. This includes: **Various** - Fix multi selection for nested blocks WordPress/gutenberg#32536 - Consistently show the drop indicator while dragging blocks WordPress/gutenberg#31896 - Fix horizontal drop indicator WordPress/gutenberg#32589 - Fix Safari flickering issue WordPress/gutenberg#32581 - Silence useSelect zombie bug errors WordPress/gutenberg#32088 **Template Editor** - Clarify the template creation modal WordPress/gutenberg#32427 - Only add skip links for block templates WordPress/gutenberg#32451 **Widgets Editor** - Add block breadcrumb WordPress/gutenberg#32498 WordPress/gutenberg#32528 WordPress/gutenberg#32569 - Saved deleted and restored widgets. WordPress/gutenberg#32534 - Fix unsaved changes detection WordPress/gutenberg#32573 - Fix button spacing in the header WordPress/gutenberg#32585 - Avoid extra undo levels WordPress/gutenberg#32572 - Move Legacy Widget block to the `@wordpress/widgets` package WordPress/gutenberg#32501 - Fix Social Links color inheritance WordPress/gutenberg#32625 - Use Button appender WordPress/gutenberg#32580 **Global Styles (theme.json)** - Separate the presets per origin in the block editor settings WordPress/gutenberg#32358 WordPress/gutenberg#32622 - Use CSS Custom Properties for the preset styles WordPress/gutenberg#32627 **Performance** - Remove is-typing classname to improve typing performance WordPress/gutenberg#32567 Props nosolosw, jorgefilipecosta, aristath, ntsekouras, peterwilsoncc, mcsf. See #53397. Built from https://develop.svn.wordpress.org/trunk@51149 git-svn-id: https://core.svn.wordpress.org/trunk@50758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
F-Wilke
pushed a commit
to FiliagoDev/WordPress
that referenced
this pull request
Jul 31, 2021
…ta 2. This includes: **Various** - Fix multi selection for nested blocks WordPress/gutenberg#32536 - Consistently show the drop indicator while dragging blocks WordPress/gutenberg#31896 - Fix horizontal drop indicator WordPress/gutenberg#32589 - Fix Safari flickering issue WordPress/gutenberg#32581 - Silence useSelect zombie bug errors WordPress/gutenberg#32088 **Template Editor** - Clarify the template creation modal WordPress/gutenberg#32427 - Only add skip links for block templates WordPress/gutenberg#32451 **Widgets Editor** - Add block breadcrumb WordPress/gutenberg#32498 WordPress/gutenberg#32528 WordPress/gutenberg#32569 - Saved deleted and restored widgets. WordPress/gutenberg#32534 - Fix unsaved changes detection WordPress/gutenberg#32573 - Fix button spacing in the header WordPress/gutenberg#32585 - Avoid extra undo levels WordPress/gutenberg#32572 - Move Legacy Widget block to the `@wordpress/widgets` package WordPress/gutenberg#32501 - Fix Social Links color inheritance WordPress/gutenberg#32625 - Use Button appender WordPress/gutenberg#32580 **Global Styles (theme.json)** - Separate the presets per origin in the block editor settings WordPress/gutenberg#32358 WordPress/gutenberg#32622 - Use CSS Custom Properties for the preset styles WordPress/gutenberg#32627 **Performance** - Remove is-typing classname to improve typing performance WordPress/gutenberg#32567 Props nosolosw, jorgefilipecosta, aristath, ntsekouras, peterwilsoncc, mcsf. See #53397. Built from https://develop.svn.wordpress.org/trunk@51149 git-svn-id: http://core.svn.wordpress.org/trunk@50758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the Legacy Widget block from
@wordpress/block-library→@wordpress/widgets.We've gone back and forth on this a little. It used to be in
@wordpress/edit-widgets. It ended up in@wordpress/block-libraryfor two reasons:Both the widgets editor (
@wordpress/edit-widgets) and customizer (@wordpress/customize-widgets) need to use the block.This is moot now that we have
@wordpress/widgetswhich is shared between the two widget editors.Solution: Move the block into
@wordpress/widgets.It's potentially useful for users to be able to use this block in the post editor and site editor.
The problem with this, though, is that most widgets won't work unless you enqueue the scripts and styles that that widget expects to have enqueued. This is a not-insignificant amount of bytes to be loading into the post and site editors for such a niche feature.
Solution: Document how a site admin can enable the Legacy Widget block in the post editor if they want it.
How has this been tested?
I performed these steps while running the plugin against both WordPress trunk and WordPress 5.7:
Checklist:
*.native.jsfiles for terms that need renaming or removal).