Remove the custom appender from the navigation block #32465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -73 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
|
From testing it looks like the main difference in behavior is that we get multiple appenders on the screen when a sub menu has focus. There's likely an alternative way of fixing this instead of depending on the renderAppender prop trunk.mp4Branch branch.mp4 |
|
Thanks for working on this. The in-canvas appender is problematic for a number of reasons, mostly that it causes layout shifts. #31886 provides a much better site editor experience by removing it entirely (which obviously isn't feasible). But what it does suggest is that we need a revised experience. I've seen some promising explorations, and I think we can find a solution, but it'll need a little time in the oven. But all that is to say: I don't think the particular navigation block appender behavior is crucial to the user experience of this block, and that the value of keeping this block behavior consistent with other blocks, outweighs the potential downsides. We need a solution for all blocks, not just this one. So no objections to removing this one if it helps. |
|
I found a simpler solution for the problem at hand (the e2e test failure) see 8bb9a8d I think we should still consider a wholistic improvement for the appender behavior, but that could be separate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #32454 I noticed that removing this custom config fixes the e2e tests, I'm not sure whether this config is required or not, in my very quick testing, it was not obvious.
This PR just tries to remove to see how the e2e tests react.