Components: promote Scrollable
#32446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Package] Components
ciampo
requested review from
youknowriad,
gziolo,
diegohaz,
tyxla and
sarayourfriend
This was referenced Jun 3, 2021
|
Size Change: +702 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Jun 7, 2021
| @@ -44,7 +44,8 @@ | |||
| "src/h-stack/**/*", | |||
| "src/v-stack/**/*", | |||
| "src/z-stack/**/*", | |||
| "src/view/**/*" | |||
| "src/view/**/*", | |||
| "src/scrollable/**/*" | |||
There was a problem hiding this comment.
Nit: should these be sorted alphabetically?
There was a problem hiding this comment.
I initially added this line in alphabetical order, but then noticed that the list is sorted until src/visually-hidden/**/* — and then I noticed that the "sorted" part of the list represents components that are marked as production-read, while the second (non-sorted) part is for experimental components.
Probably the best person to answer about this would be @sarayourfriend , but maybe we keep this change as-is for now and if needed sort this list alphabetically in one of the future PRs?
There was a problem hiding this comment.
Good point! I tried to give an explanation here
There was a problem hiding this comment.
Oh, that's a good point 👍 Thanks for elaborating
There was a problem hiding this comment.
Hmmm, I don't think any of that is intentional. Sorting them alphabetically is fine with me. If we want to make a separation between the experimental and prod components we should add a comment explaining that and add some spacing to make it more obvious.
Though TBH I don't think it's worth the effort to maintain two separate lists. I'd rather we just opened a PR like Marco suggested to sort them once and for all.
There was a problem hiding this comment.
Just wanted to stress that this is totally a minor deal. Maybe we can sort these when we touch the list the next time, but there's definitely no need to make a special PR just to sort them. It's why I prefaced my first comment with "nit: " 😉
|
|
||
| export default { | ||
| component: Scrollable, | ||
| title: 'G2 Components (Experimental)/Scrollable', | ||
| title: 'Components (Experimental)/Scrollable', |
There was a problem hiding this comment.
I think it would have been useful if the story allowed us to change the scroll direction and toggle the smooth scroll option.
6 tasks
nenel1221
reviewed
Jun 14, 2021
| import { useScrollable } from './hook'; | ||
|
|
||
| /** | ||
| * `Scrollable` is a layout component that content in a scrollable container. | ||
| * | ||
| * @example | ||
| * ```jsx | ||
| * import { Scrollable } from `@wordpress/components/ui`; | ||
| * import { __experimentalScrollable as Scrollable } from `@wordpress/components/ui`; |
There was a problem hiding this comment.
Hey @nenel1221 , I'm not sure I'm getting your comment — could you elaborate, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Promote the
Scrollablecomponent from thepackages/components/src/uito thepackages/components/srcfolder.@wordpress/componentsas__experimentalScrollableTesting instructions
trunk)Screenshots
Types of changes
Refactor
Checklist:
*.native.jsfiles for terms that need renaming or removal).