Components: promote Surface
#32439
Merged
Components: promote Surface
#32439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Package] Components
ciampo
requested review from
tyxla,
sarayourfriend,
youknowriad,
diegohaz and
gziolo
This was referenced Jun 3, 2021
ciampo
commented
Jun 3, 2021
|
|
||
| Determines the grid size for "dotted" and "grid" variants. | ||
|
|
||
| ##### border | ||
| ### `border`: `boolean` |
There was a problem hiding this comment.
I'm not personally sure about the APIs around border.
Currently, there are 5 different props:
bordershows the border on all four sidesborder{Top,Left,Right,Bottom}each show one individual border
It feels a bit weird to me that there is partial overlap between them — i.e. that if border is true, all other props become meaningless
There was a problem hiding this comment.
Agreed, this doesn't make much sense to me, especially if we consider how borders behave in CSS. I guess it makes sense that the border* take precedence over border, but that might also require a change in the default values of those props.
There was a problem hiding this comment.
Regardless of what we decide here, it makes sense to document how all those border props behave, and which one takes precedence over the other(s).
There was a problem hiding this comment.
Probably the easiest solution that I see is to remove the border prop, and leave the remaining individual props as they are. That would avoid overlaps and only make setting a border around the whole surface a bit more verbose.
WDYT?
There was a problem hiding this comment.
I'd say I can see some value in having them separate, but I'd likely have the border* default to the current value of border of not specified. I think that would be easy, too, and would solve the problem, while still resembling how border specificity works in CSS. What do you think about that?
There was a problem hiding this comment.
As discussed with @tyxla , we decided to remove the border prop for now and simplify the component's APIs
|
Size Change: +546 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Jun 7, 2021
| @@ -44,7 +44,8 @@ | |||
| "src/h-stack/**/*", | |||
| "src/v-stack/**/*", | |||
| "src/z-stack/**/*", | |||
| "src/view/**/*" | |||
| "src/view/**/*", | |||
| "src/surface/**/*" | |||
There was a problem hiding this comment.
Nit: seems like we don't quite follow an alphabetical sorting order here
|
|
||
| Determines the grid size for "dotted" and "grid" variants. | ||
|
|
||
| ##### border | ||
| ### `border`: `boolean` |
There was a problem hiding this comment.
Agreed, this doesn't make much sense to me, especially if we consider how borders behave in CSS. I guess it makes sense that the border* take precedence over border, but that might also require a change in the default values of those props.
|
|
||
| Determines the grid size for "dotted" and "grid" variants. | ||
|
|
||
| ##### border | ||
| ### `border`: `boolean` |
There was a problem hiding this comment.
Regardless of what we decide here, it makes sense to document how all those border props behave, and which one takes precedence over the other(s).
ciampo
force-pushed
the
feat/components-promote-surface
branch
from
45c8f4a to
f9761ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Promote the
Surfacecomponent from thepackages/components/src/uito thepackages/components/srcfolder.@wordpress/componentsas__experimentalSurfaceTesting instructions
trunk)Screenshots
Types of changes
Refactor
Checklist:
*.native.jsfiles for terms that need renaming or removal).