wp-env: Edit PHP configuration with htaccess from .wp-env.json. #32363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +437 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
|
I think based on our conversations in #28703, we don't want to expose php config to the end user. That said, I think it'd be super useful to increase the default sizes the environment uses. I don't think there is a reason for them to be so small. What do you think about just increasing those sizes without adding a config entry? Relatedly, are there actually config entries folks would need to change, or is it mostly just that the defaults aren't good? cc @ockham |
|
The default size is 2MB, which I think is very small. For example, this is not enough for a large jpeg image. Also, when importing data using plugins such as All-in-One WP Migration, the file size often exceeds 1GB. I think you need to set the default value to huge. I think you need to set the default value to huge. It is difficult to determine what is the right size to set. |
Procorners
approved these changes
Apr 5, 2022
|
I came across this PR while checking for PRs that haven't been reviewed in a long time. #50490 seems to have raised the default upload size to 1GB. Additionally, you can change various settings by mapping the
{
"mappings": {
".htaccess": "./path/to/.htaccess"
}
}
Therefore, I would like to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #28703 and #29430. Related: #30377.
This PR makes it possible to edit PHP configuration via htaccess from .wp-env.json.
wp-env.json
{ "core": "WordPress/WordPress", "phpConfig": { "post_max_size": "4G", "upload_max_filesize": "4G" } }.httacess
How has this been tested?
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).