[RNMobile] Audio block local url parsing fix #32291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-alexander
added
Mobile App - i.e. Android or iOS
2 tasks
|
Size Change: 0 B Total Size: 1.85 MB ℹ️ View Unchanged
|
This was referenced May 27, 2021
Closed
dcalhoun
approved these changes
May 27, 2021
Great! Thanks for the review @dcalhoun 👍🏾 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg-MobilePR wordpress-mobile/gutenberg-mobile#3558WP AndroidPR wordpress-mobile/WordPress-Android#14738WP iOSPR wordpress-mobile/WordPress-iOS#16589Description
Reverted the changes done to the URL parsing logic within the
audio-playersince it doesn't cover all URL types that are supported by the Audio block, in particular local files.How has this been tested?
npm run test-unit:nativeand they all passed.Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).