Performance tests: add more detailed loading metrics #32237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
ellatrix
force-pushed
the
add/detailed-loading-performance-times
branch
from
5f2e1f8 to
87d5f2c
Compare
ellatrix
changed the title
|
This is hugely helpful for improving loading performance and tracking down regressions. It will work old releases as well. It's a fairly small and isolated change so merging soon if there's no objections. |
youknowriad
reviewed
May 26, 2021
There was a problem hiding this comment.
This is cool. Should we take this to improve our "perf metrics" documentation with all the measures. (the description of the PR is helpful) https://developer.wordpress.org/block-editor/explanations/architecture/performance/#metrics
|
Do you think the measures after first byte should subtract the "first byte" one to get more stable results across runs (exclude server/latency flakiness) |
|
@youknowriad Yeah, been thinking about that. I don't see it being done normally in performance metrics, so I'm hesitant about it. I'm actually changing it to |
|
@ellatrix about the subtraction, I don't feel strongly right now, so we can do whatever you think is best for now. |
|
I'm subtracting it, it does make sense. It could be a bit misleading for other times, for example you may think that time to first block includes the server response time. I'll just add a comment so that's clear. |
ellatrix
force-pushed
the
add/detailed-loading-performance-times
branch
from
c103460 to
f6a096b
Compare
|
It's interesting that trunk's first paint (since response end) is five times quicker than this branch. Rebased to see it changes anything. |
7 tasks
ellatrix
force-pushed
the
add/detailed-loading-performance-times
branch
from
f6a096b to
86f0b68
Compare
ellatrix
force-pushed
the
add/detailed-loading-performance-times
branch
from
86f0b68 to
7ff2938
Compare
|
Let's merge this. It only modifies the tests. We really need some more detailed metrics for loading. |
youknowriad
reviewed
Oct 12, 2021
| serverResponse: average( results.serverResponse ), | ||
| firstPaint: average( results.firstPaint ), | ||
| domContentLoaded: average( results.domContentLoaded ), | ||
| loaded: average( results.loaded ), |
There was a problem hiding this comment.
Do you think we can restore the "load" metric (in addition to these). I know it's not perfect but the history of http://codehealth.vercel.app relies on it. We can update the dashboards to use the other tools later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds more detailed loading metrics. Currently it's hard to measure any improvements made without seeing more fine grained results.
requestStartandresponseStart.responseEnd.DOMContentLoadedevent completes. SeedomContentLoadedEventEnd. (TheDOMContentLoadedevent fires when the initial HTML document has been completely loaded and parsed, without waiting for stylesheets, images, and subframes to finish loading.)loadEventEnd. (Theloadevent is fired when the whole page has loaded, including all dependent resources such as stylesheets and images.)How has this been tested?
Check the performance job.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).