Move react-native-url-polyfill to devDep in @wordpress/url #32207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer necessary as a runtime dependency after is-url.native.js was removed
gziolo
reviewed
Jun 7, 2021
| "lodash": "^4.17.21", | ||
| "lodash": "^4.17.21" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
Development dependencies won't install from packages. They need to be listed in the main package.json file.
|
CI reports some issues, but most of them should be resolved with a rebase. |
ramonjd
added
[Package] Url
|
Closing in favor of #34687. Thank you for starting this PR. I addressed my own comment in a new branch since I couldn't apply them here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved the runtime react-native-url-polyfill to a devDependency. No longer necessary as a runtime dependency after is-url.native.js was removed
How has this been tested?
Tests pass
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).