components: Remove all withNext wrappers
#32205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
|
Size Change: -10 kB (-1%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
remove/next-wrappers
branch
from
39cd496 to
da68e43
Compare
ciampo
reviewed
May 26, 2021
| @@ -19,8 +19,7 @@ | |||
| "npm": ">=6.9.0 <7" | |||
| }, | |||
| "config": { | |||
| "GUTENBERG_PHASE": 2, | |||
| "COMPONENT_SYSTEM_PHASE": 1 | |||
There was a problem hiding this comment.
The only instance of COMPONENT_SYSTEM_PHASE left in the codebase would be in the changelog, which raises the question: should this change be also added as a changelog entry?
There was a problem hiding this comment.
🤔 Not sure @gziolo ?
ciampo
approved these changes
May 26, 2021
There was a problem hiding this comment.
The project builds correctly, and I compared the local Storybook version of Tooltip and VisuallyHidden components against the production version without noticing any differences
LGTM 🚀
sarayourfriend
force-pushed
the
remove/next-wrappers
branch
2 times, most recently
from
8a55309 to
b42224e
Compare
sarayourfriend
force-pushed
the
remove/next-wrappers
branch
from
b42224e to
48a2769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because we're moving away from this strategy (see #30503 for details) we can remove the
withNextcomponent wrappers.How has this been tested?
Run storybook and gutenberg and ensure components and the app work as expected.
Types of changes
Clean up.
Checklist:
*.native.jsfiles for terms that need renaming or removal).