Fix widget editor block toolbar scrolling behavior #32177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Regression
talldan
requested review from
kevin940726,
noisysocks and
tellthemachines
as code owners
talldan
commented
May 25, 2021
| @@ -1,6 +1,7 @@ | |||
| .edit-widgets-block-editor { | |||
| position: relative; | |||
| background: $gray-100; | |||
| padding: 0; | |||
There was a problem hiding this comment.
Ensures the top toolbar and notices have no gap above them.
|
Size Change: +4 B (0%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
May 25, 2021
| </ObserveTyping> | ||
| </WritingFlow> | ||
| </BlockSelectionClearer> | ||
| <BlockTools> |
There was a problem hiding this comment.
BlockTools should be wrapped around the editor canvas (.editor-styles-wrapper). It should not be part of the canvas.
ellatrix
reviewed
May 25, 2021
| </WritingFlow> | ||
| </BlockSelectionClearer> | ||
| <BlockTools> | ||
| <Notices /> |
There was a problem hiding this comment.
Similarly, notices should not be part of the editor canvas.
7 tasks
|
The issue will be fixed by #32212 |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related #32178
Fixes an issue where the block toolbar doesn't stay anchored to the block in the customize widget editor. For some reason,
BlockToolsis very particular about where it should be rendered, it seems to need to be in the editor styles wrapper.This seems to be an issue with
BlockToolsacross multiple editors (Widget, Navigation, Storybook Playground), but is most obvious in the standalone widget editor (also the most important place to fix).How has this been tested?
wp.data.dispatch( 'core/notices' ).createInfoNotice( 'hello' );Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).