compose: Add types to useThrottle and typecheck useFocusOutside
#32170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Code Quality
|
Size Change: -15 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
add/types-compose-focus-outside
branch
from
8974233 to
f8b93a0
Compare
tyxla
reviewed
May 25, 2021
| * @param {TFunc} fn The function to throttle. | ||
| * @param {number} [wait] The number of milliseconds to throttle invocations to. | ||
| * @param {import('lodash').ThrottleSettings} [options] The options object. See linked documentation for details. | ||
| * @return {TFunc & import('lodash').Cancelable} Throttled function. |
There was a problem hiding this comment.
Should this use DebouncedFunc instead?
There was a problem hiding this comment.
Agreed, it seems like this could be a more up-to-date way of typing it:
Suggested change
| * @return {TFunc & import('lodash').Cancelable} Throttled function. | |
| * @return {import('lodash').DebouncedFunc<TFunc>} Throttled function. |
Although it seems like there isn't any DebouncedFunc export, at least in the version of lodash that is being used. DebouncedFunc was introduced almost a year ago
There was a problem hiding this comment.
Yeah I don't see DebouncedFunc in the declarations available to us 🤔
ciampo
force-pushed
the
add/types-compose-focus-outside
branch
from
f8b93a0 to
6384cf4
Compare
|
While @sarayourfriend is AFK I will take over this PR — I just rebased on top of @tyxla do you mind having another round of review? |
tyxla
approved these changes
Jun 1, 2021
| @@ -19,21 +19,23 @@ | |||
| "src/higher-order/with-global-events/**/*", | |||
| "src/hooks/use-async-list/**/*", | |||
| "src/hooks/use-constrained-tabbing/**/*", | |||
| "src/hooks/use-copy-on-click/**/*", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds types to
useThrottleand includesuseFocusOutsideto typechecking (it was already comprehensively typed).Part of #18838
How has this been tested?
Type checks pass. No runtime changes except for explicit arguments for
useThrottlebut the functions are equivalent.Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).