-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Screen: Hide sidebar when a menu isn't selected #32090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
adamziel,
draganescu,
getdave,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
May 21, 2021 12:12
Mamaduka
added
[Feature] Navigation Screen
[Type] Regression
Related to a regression in the latest release
labels
May 21, 2021
getdave
approved these changes
May 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ All good to go.
Noticed one visual glitch (for a followup PR?) which is as the sidebar starts to appear the Switch menu
and Save
buttons are placed above it for a split second.
To replicate:
- Delete all Menus.
- Create new Menu.
- Watch sidebar area closely.
- See buttons placed above sidebar in CSS layout glitch for a split second as the sidebar appears.
Screen.Capture.on.2021-05-21.at.18-05-20.mov
Mamaduka
force-pushed
the
fix/hide-sidebar-when-no-menus
branch
from
May 22, 2021 08:38
b57d7f1
to
6f37b2b
Compare
Fixed the glitch. |
Size Change: -9 B (0%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
fix/hide-sidebar-when-no-menus
branch
from
May 25, 2021 03:01
6f37b2b
to
8423367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The setting sidebar shouldn't be displayed when a menu isn't selected.
Fixes regression introduced in #31821.
How has this been tested?
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).