Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Preview Menu extensible #31984

Closed
wants to merge 22 commits into from
Closed

Make the Preview Menu extensible #31984

wants to merge 22 commits into from

Commits on May 24, 2021

  1. Allow Preview menu to be extendible by plugins: WIP

    @mreishus @delawski
    mreishus authored and delawski committed May 24, 2021
    Configuration menu
    Copy the full SHA
    81d03cb View commit details
    Browse the repository at this point in the history

  2. PluginPreview{MenuItem,}: Change external interface "deviceName" -> "… 

    …previewId"
    @mreishus @delawski
    mreishus authored and delawski committed May 24, 2021
    Configuration menu
    Copy the full SHA
    64cb27d View commit details
    Browse the repository at this point in the history

  3. Decouple PluginPreviewMenuItem from @wordpress/edit-post

    @delawski
    delawski committed May 24, 2021
    Configuration menu
    Copy the full SHA
    a690338 View commit details
    Browse the repository at this point in the history

  4. Retrieve previewId in parent component

    @delawski
    delawski committed May 24, 2021
    Configuration menu
    Copy the full SHA
    bfb8976 View commit details
    Browse the repository at this point in the history

  5. Accept custom onClick handler and icon in plugin preview

    @delawski
    delawski committed May 24, 2021
    Configuration menu
    Copy the full SHA
    36bca61 View commit details
    Browse the repository at this point in the history

  6. Update jsdoc blocks

    @delawski
    delawski committed May 24, 2021
    Configuration menu
    Copy the full SHA
    5a93322 View commit details
    Browse the repository at this point in the history

  7. Check previewId aka deviceType directly in child component

    @delawski
    delawski committed May 24, 2021
    Configuration menu
    Copy the full SHA
    d7c329e View commit details
    Browse the repository at this point in the history

  8. Update coreDeviceTypes docs

    @delawski
    delawski committed May 24, 2021
    Configuration menu
    Copy the full SHA
    18f2596 View commit details
    Browse the repository at this point in the history

  9. Update slotfills docs

    @delawski
    delawski committed May 24, 2021
    Configuration menu
    Copy the full SHA
    f4e401b View commit details
    Browse the repository at this point in the history

  10. Do not expose menu item fill; simplify PluginPreview component 

    As per the review feedback, there seems to be no need to expose the Preview menu item fill at all. It should be sufficient to expose the title, icon, and click handler. This way we "protect" the Preview menu drop-down from injecting arbitrary, irrelevant elements into it.

Thanks to that, the entire custom previews implementation could be simplified. It's now mostly contained within the `PluginPreview` component itself.
    @delawski
    delawski committed May 24, 2021
    Configuration menu
    Copy the full SHA
    f949647 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. Allow Preview menu to be extendible by plugins: WIP

    @mreishus @arcangelini
    mreishus authored and arcangelini committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    9abd3d0 View commit details
    Browse the repository at this point in the history

  2. PluginPreview{MenuItem,}: Change external interface "deviceName" -> "… 

    …previewId"
    @mreishus @arcangelini
    mreishus authored and arcangelini committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    5907441 View commit details
    Browse the repository at this point in the history

  3. Decouple PluginPreviewMenuItem from @wordpress/edit-post

    @delawski @arcangelini
    delawski authored and arcangelini committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    0a7d495 View commit details
    Browse the repository at this point in the history

  4. Retrieve previewId in parent component

    @delawski @arcangelini
    delawski authored and arcangelini committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    cd9a6d1 View commit details
    Browse the repository at this point in the history

  5. Accept custom onClick handler and icon in plugin preview

    @delawski @arcangelini
    delawski authored and arcangelini committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    dc79b50 View commit details
    Browse the repository at this point in the history

  6. Update jsdoc blocks

    @delawski @arcangelini
    delawski authored and arcangelini committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    866e5c8 View commit details
    Browse the repository at this point in the history

  7. Check previewId aka deviceType directly in child component

    @delawski @arcangelini
    delawski authored and arcangelini committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    a309d23 View commit details
    Browse the repository at this point in the history

  8. Update coreDeviceTypes docs

    @delawski @arcangelini
    delawski authored and arcangelini committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    4cd2075 View commit details
    Browse the repository at this point in the history

  9. Update slotfills docs

    @delawski @arcangelini
    delawski authored and arcangelini committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    ee1fba2 View commit details
    Browse the repository at this point in the history

  10. Do not expose menu item fill; simplify PluginPreview component 

    As per the review feedback, there seems to be no need to expose the Preview menu item fill at all. It should be sufficient to expose the title, icon, and click handler. This way we "protect" the Preview menu drop-down from injecting arbitrary, irrelevant elements into it.

Thanks to that, the entire custom previews implementation could be simplified. It's now mostly contained within the `PluginPreview` component itself.
    @delawski @arcangelini
    delawski authored and arcangelini committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    0301e1d View commit details
    Browse the repository at this point in the history

  11. Merge branch 'add/preview-menu-slot' of https://github.com/delawski/g… 

    …utenberg into add/preview-menu-slot
    @arcangelini
    arcangelini committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    2236783 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Merge remote-tracking branch 'upstream/trunk' into add/preview-menu-slot

    @arcangelini
    arcangelini committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    76c3106 View commit details
    Browse the repository at this point in the history