Try to fix PHP unit tests #31981
Closed
Try to fix PHP unit tests #31981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
May 19, 2021
| 'padding' => array( | ||
| 'top' => '1px', | ||
| 'right' => '1px', | ||
| 'bottom' => 'var(--unsafe-var-toplevel)', |
There was a problem hiding this comment.
Maybe instead we should test for something else.
There was a problem hiding this comment.
ellatrix
force-pushed
the
try/fix-php-unit-tests
branch
from
04db092 to
efd1e0e
Compare
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
ellatrix
commented
May 19, 2021
| @@ -586,7 +586,7 @@ function test_remove_insecure_properties_removes_unsafe_styles_sub_properties() | |||
| 'padding' => array( | |||
| 'top' => '2px', | |||
| 'right' => '2px', | |||
| 'bottom' => 'var(--unsafe-var-elements)', | |||
There was a problem hiding this comment.
@nosolosw Btw, I noticed that these are not stripped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cause: WordPress/wordpress-develop@8e498a8
var()is now allowed, so we need to update the tests.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).