Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore data-no-store-string-literals rule for native files #31936

Merged
merged 1 commit into from
May 18, 2021

Conversation

aristath
Copy link
Member

@aristath aristath commented May 18, 2021

Description

Came up in a discussion with @gziolo after the comment on #31934 (comment)

Ignoring the rule for native files will prevent the next person from making the same mistake I did.

How has this been tested?

Running npm run lint-js no longer throws warnings for native files for the data-no-store-string-literals check.

Types of changes

Turned off the @wordpress/data-no-store-string-literals rule for native files in the .eslintrc.js file.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@aristath aristath requested a review from gziolo May 18, 2021 13:31
@gziolo gziolo added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Code Quality Issues or PRs that relate to code quality labels May 18, 2021
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's do it. There is #29655 filed which should include a note to turn this flag on again when violations are fixed.

@aristath aristath merged commit 88959ff into trunk May 18, 2021
@aristath aristath deleted the add/eslint-ignore-native-string-literals branch May 18, 2021 20:00
@github-actions github-actions bot added this to the Gutenberg 10.7 milestone May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants