UnitControl: Fixed documentation for units
attribute
#31901
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes typos and omissions in documentation and Storybook to properly document the property
units
of the UnitControl component.Problem solved: When looking at storybook & docs, it was unclear if/how we could define the units available in the component
<UnitControl/>
.How has this been tested?
I created a demo here to make sure the syntax is correct: https://codesandbox.io/s/beautiful-burnell-3d4gm?file=/src/App.js and ran
npm run storybook:dev
to test the Storybook result (see screenshots).Screenshots
See it in action: https://user-images.githubusercontent.com/5040227/118523628-3711df80-b735-11eb-9623-3d698a7137f9.mp4
Types of changes
Documentation fixes (non-breaking)
Checklist:
*.native.js
files for terms that need renaming or removal).