Revert "components: Promote VisuallyHidden from ui into full components (#31244)" #31882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ajitbohra,
chrisvanpatten and
ellatrix
as code owners
youknowriad
added
[Feature] UI Components
|
Size Change: +477 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
May 17, 2021
aristath
approved these changes
May 17, 2021
7 tasks
sarayourfriend
added a commit
that referenced
this pull request
Jul 17, 2021
…components (#31244)"" (#31902) * Revert "Revert "components: Promote VisuallyHidden from ui into full components (#31244)" (#31882)" This reverts commit 269f31a. * Convert to styled component * Update snapshots * Add children prop * Use View naming convention * Use inline styles and remove focus styles * Update color picker snapshots * Render a View to allow for polymorphism and forward the ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31562
This reverts commit fda8d09.
The migration to the new VisuallyHidden component created some visual issues in iframed editors like #31562
Some folks are also seeing broken block editor toolbars in the post editor (without iframe)
This PR reverts that commit temporarily so we can have time to debug it properly.