Enable justification for burger menu. #31877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.56 kB (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
|
@jasmussen this works well in my testing: Before:
After:
However, would it be possible to apply the alignment choice to the hamburger itself? It's currently left-aligned all the time no matter which option you choose:
I know that "alignment" is technically different than "justification", but I expected to work that way. |
|
Great call. Done:
|
kjellr
approved these changes
May 17, 2021
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31845.
The recently landed burger menu feature adds a few containers. Some of these containers broke the justification. This PR fixes that:
How has this been tested?
Please insert a navigation block. Enable responsiveness in the inspector. Try the various alignments, left, center, right, justify. Verify they look correct on the frontend and editor. Please try also the responsive feature, with the menu open and closed.
Checklist:
*.native.jsfiles for terms that need renaming or removal).