Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] - Refactor gallery - cherry pick image edit native #31826

3 changes: 2 additions & 1 deletion packages/block-library/src/gallery/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@
},
"providesContext": {
"allowResize": "allowResize",
"isGrouped": "isGrouped"
"isGrouped": "isGrouped",
"imageCrop": "imageCrop",
},
"supports": {
"anchor": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/image/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "core/image",
"title": "Image",
"category": "media",
"usesContext": [ "allowResize", "isGrouped" ],
"usesContext": [ "allowResize", "isGrouped", "imageCrop" ],
"description": "Insert an image to make a visual statement.",
"keywords": [ "img", "photo", "picture" ],
"textdomain": "default",
Expand Down
104 changes: 70 additions & 34 deletions packages/block-library/src/image/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,11 @@ import { store as coreStore } from '@wordpress/core-data';
import styles from './styles.scss';
import { getUpdatedLinkTargetSettings } from './utils';

import { LINK_DESTINATION_CUSTOM } from './constants';
import {
LINK_DESTINATION_CUSTOM,
LINK_DESTINATION_ATTACHMENT,
LINK_DESTINATION_MEDIA,
} from './constants';

const getUrlForSlug = ( image, { sizeSlug } ) => {
return get( image, [ 'media_details', 'sizes', sizeSlug, 'source_url' ] );
Expand Down Expand Up @@ -167,10 +171,10 @@ export class ImageEdit extends Component {
}

componentDidUpdate( previousProps ) {
if ( ! previousProps.image && this.props.image ) {
const { image, attributes } = this.props;
const { image, attributes, setAttributes } = this.props;
if ( ! previousProps.image && image ) {
const url = getUrlForSlug( image, attributes ) || image.source_url;
this.props.setAttributes( { url } );
setAttributes( { url } );
}
}

Expand Down Expand Up @@ -283,14 +287,13 @@ export class ImageEdit extends Component {
}

onSetSizeSlug( sizeSlug ) {
const { image } = this.props;
const { image, setAttributes } = this.props;

const url = getUrlForSlug( image, { sizeSlug } );
if ( ! url ) {
return null;
}

this.props.setAttributes( {
setAttributes( {
url,
width: undefined,
height: undefined,
Expand All @@ -299,11 +302,8 @@ export class ImageEdit extends Component {
}

onSelectMediaUploadOption( media ) {
const {
attributes: { id, url },
imageDefaultSize,
} = this.props;

const { imageDefaultSize } = this.props;
const { id, url, destination } = this.props.attributes;
const mediaAttributes = {
id: media.id,
url: media.url,
Expand All @@ -323,6 +323,17 @@ export class ImageEdit extends Component {
additionalAttributes = { url };
}

let href;
switch ( destination ) {
case LINK_DESTINATION_MEDIA:
href = media.url;
break;
case LINK_DESTINATION_ATTACHMENT:
href = media.link;
break;
}
mediaAttributes.href = href;

this.props.setAttributes( {
...mediaAttributes,
...additionalAttributes,
Expand Down Expand Up @@ -363,17 +374,24 @@ export class ImageEdit extends Component {

setMappedAttributes( { url: href, ...restAttributes } ) {
const { setAttributes } = this.props;

return href === undefined
? setAttributes( restAttributes )
: setAttributes( { ...restAttributes, href } );
? setAttributes( {
...restAttributes,
linkDestination: LINK_DESTINATION_CUSTOM,
} )
: setAttributes( {
...restAttributes,
href,
linkDestination: LINK_DESTINATION_CUSTOM,
} );
}

getLinkSettings() {
const { isLinkSheetVisible } = this.state;
const {
attributes: { href: url, ...unMappedAttributes },
} = this.props;

const mappedAttributes = { ...unMappedAttributes, url };

return (
Expand Down Expand Up @@ -438,6 +456,7 @@ export class ImageEdit extends Component {
image,
clientId,
imageDefaultSize,
context: { isGrouped = false, imageCrop = false },
featuredImageId,
wasBlockJustInserted,
} = this.props;
Expand Down Expand Up @@ -516,6 +535,13 @@ export class ImageEdit extends Component {
wide: 'center',
};

const additionalImageProps = isGrouped
? {
height: '100%',
resizeMode: imageCrop ? 'cover' : 'contain',
}
: {};

const getImageComponent = ( openMediaOptions, getMediaOptions ) => (
<Badge label={ __( 'Featured' ) } show={ isFeaturedImage }>
<TouchableWithoutFeedback
Expand Down Expand Up @@ -548,25 +574,35 @@ export class ImageEdit extends Component {
retryMessage,
} ) => {
return (
<Image
align={ align && alignToFlex[ align ] }
alt={ alt }
isSelected={
isSelected && ! isCaptionSelected
}
isUploadFailed={ isUploadFailed }
isUploadInProgress={
isUploadInProgress
}
onSelectMediaUploadOption={
this.onSelectMediaUploadOption
}
openMediaOptions={ openMediaOptions }
retryMessage={ retryMessage }
url={ url }
shapeStyle={ styles[ className ] }
width={ this.getWidth() }
/>
<View
style={ isGrouped && styles.isGallery }
>
<Image
align={
align && alignToFlex[ align ]
}
alt={ alt }
isSelected={
isSelected &&
! isCaptionSelected
}
isUploadFailed={ isUploadFailed }
isUploadInProgress={
isUploadInProgress
}
onSelectMediaUploadOption={
this.onSelectMediaUploadOption
}
openMediaOptions={
openMediaOptions
}
retryMessage={ retryMessage }
url={ url }
shapeStyle={ styles[ className ] }
width={ this.getWidth() }
{ ...additionalImageProps }
/>
</View>
);
} }
/>
Expand Down
5 changes: 5 additions & 0 deletions packages/block-library/src/image/styles.native.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,8 @@
padding-right: 0;
padding-bottom: $grid-unit;
}

.isGallery {
height: 150;
overflow: visible;
}