Plugin: Tweaks to accommodate latest changes in core for styles loading #31702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
the
Backwards Compatibility
aristath
commented
May 11, 2021
| @@ -170,6 +170,7 @@ function gutenberg_register_core_block_styles( $block_name ) { | |||
| $editor_style_path = "build/block-library/blocks/$block_name/style-editor.css"; | |||
|
|
|||
| if ( file_exists( gutenberg_dir_path() . $style_path ) ) { | |||
| wp_deregister_style( "wp-block-{$block_name}" ); | |||
There was a problem hiding this comment.
Deregister styles so they can be registered properly. This is needed in WP5.8, and irrelevant in previous versions.
There was a problem hiding this comment.
gutenberg_override_style should be a nice shortcut.
aristath
commented
May 11, 2021
aristath
commented
May 11, 2021
gziolo
added
the
Gutenberg Plugin
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
gziolo
approved these changes
May 11, 2021
There was a problem hiding this comment.
I haven't tested but code-wise it looks good. This is exactly what I discussed with @aristath in the private chat.
We could optionally backport it to Gutenberg 10.6 release to ensure there are no reports related to incompatibility with WordPress core when using trunk.
gziolo
changed the title
|
I added this to the 10.6 milestone as suggested above by @gziolo cc @vdwijngaert |
vdwijngaert
pushed a commit
that referenced
this pull request
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A commit was backported from Gutenberg to core to allow loading separate stylesheets per-block on render - See https://core.trac.wordpress.org/changeset/50836
This PR tweaks Gutenberg to make sure nothing breaks when using WP5.8.
How has this been tested?
Tested with WordPress trunk, using the default theme, with and without this line in the theme's
functions.phpfile:Also tested with a block theme with and without the filter.
Using the default theme, without the filter it loads the single
style.cssfile for all blocks. With the filter, it loads separate styles.Using a block theme the separate styles get loaded properly.
Checklist:
*.native.jsfiles for terms that need renaming or removal).