Polish the switcher for horizontal blocks. #31645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
CSS Styling
|
Size Change: +8 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
May 10, 2021
dcalhoun
approved these changes
May 12, 2021
|
Thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR polishes the parent button, and the switcher for horizontally moving blocks. It's best explained with a GIF. Before:
After:
What you see here is:
How has this been tested?
Please test blocks that move horizontally and verify the type icon is correctly positioned.
Please test child blocks where you select the parent block.
Please test on mobile, desktop, and with top toolbar enabled.
BONUS points if you check with some plugins that add buttons.
All of it should be fine.
Checklist:
*.native.jsfiles for terms that need renaming or removal).