components: Promote Elevation #31614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
|
Size Change: +415 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
add/promote-elevation
branch
from
188e3aa to
4baf53a
Compare
sarayourfriend
force-pushed
the
add/promote-elevation
branch
2 times, most recently
from
ef2bc09 to
3ad56ec
Compare
ciampo
reviewed
May 20, 2021
There was a problem hiding this comment.
Code changes look good! I compared this PR against previous "promotion" PRs and came up with a couple of notes:
- Should we add a changelog entry?
- I noticed that
packages/components/tsconfig.jsondoesn't include all components — for example, should<Divider />be listed there?
Finally, one last nit: the README states for the value prop:
"In the example below, isInteractive is activated to give a better sense of depth."
but there isn't any example below that paragraph.
I also rebased on top of latest trunk
ciampo
force-pushed
the
add/promote-elevation
branch
from
3ad56ec to
df501ae
Compare
I think we decided not to add changelog entries for the introduction of experimental components, so no, not in this particular case.
Yes it should be in there! I'll open a separate PR to make sure they're all included. |
ciampo
approved these changes
May 20, 2021
There was a problem hiding this comment.
Given that there's no need for a changelog entry, and that any missing components in tsconfig.json will be added in a separate PR, the only review comment left to be addressed is:
Finally, one last nit: the README states for the value prop: "In the example below, isInteractive is activated to give a better sense of depth." but there isn't any example below that paragraph.
Once addressed, this PR is good to go!
ciampo
reviewed
May 21, 2021
sarayourfriend
force-pushed
the
add/promote-elevation
branch
from
0b217aa to
841c9cd
Compare
fullofcaffeine
added a commit
that referenced
this pull request
May 22, 2021
…-take-2 * trunk: (57 commits) Image block: fix cover transform and excessive re-rendering (#32102) compose: Add types to useMergeRefs (#31939) Navigation: Fix collapsing regression. (#32081) components: Promote Elevation (#31614) compose: Add types to useReducedMotion and useMediaQuery (#31941) Update the graphic that appears in the Template Editor welcome guide (#32055) Block Navigation: use CSS for indentation with known max indent instead of spacer divs (#32063) Fix broken template part converter modal styles. (#32097) compose: Add types to `usePrevious` (#31944) components: Add ZStack (#31613) components: Fix Shortcut polymorphism (#31555) compose: Add types to `useFocusReturn` (#31949) compose: Add types to `useDebounce` (#32015) List View: Simplify the BlockNavigation component (#31290) Remove query context leftovers (#32093) Remove filter_var from blocks (#32046) Templates: Remove now-obsolete gutenberg_get_template_paths() (#32066) [RNMobile] Enable reusable block only in WP.com sites (#31744) Rename ViewOwnProps to PolymorphicComponentProps (#32053) Rich text: remove inline display warning (#32013) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Promotes the
Elevationcomponent to a full export.How has this been tested?
Storybook, type check and unit tests should pass.
Types of changes
New feature.
Checklist:
*.native.jsfiles for terms that need renaming or removal).