Fix toolbar in device preview #31600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +17 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
7 tasks
ellatrix
force-pushed
the
fix/toolbar-device-preview
branch
from
4ba2324 to
7b107b8
Compare
ellatrix
force-pushed
the
fix/toolbar-device-preview
branch
from
ba0da7b to
5fac8b4
Compare
|
This is the before:
And this PR is a good improvement, it moves the top toolbar out, so it sits and has comfortable space. However I'm seeing this:
That's using "Empty Theme". I think it's the min-height: 100%; rule you removed here: https://github.com/WordPress/gutenberg/pull/31600/files#diff-5e55c7c9e7afd644f3829ad8df092bcb826a1881ca57cc6df51100414d78042fL41 Here's a GIF:
Using Chrome. |
|
@jasmussen Yes, that's what the e2e test is catching too. :) I'll fix it in a bit |
ellatrix
force-pushed
the
fix/toolbar-device-preview
branch
from
5fac8b4 to
1525ab7
Compare
ellatrix
force-pushed
the
fix/toolbar-device-preview
branch
from
1525ab7 to
2247d5f
Compare
|
I thoroughly tested this in the post editor, template editor and FSE both with and without a fixed toolbar and with all device types and it works really well. We really need this because the toolbar is broken when previewing devices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It should look like this:
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).