Fix stylesheet dependency for the post-comment-form block #31528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
carolinan
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #31338 the
post-comments-formblock inherits styles from the button block for the form-submit button. In block themes (or classic themes that opted-in), block styles get loaded separately. So if a page has a post-comments-form block but not a button block, styles for the button don't get loaded and the form-submit button is unstyled.This PR adds a dependency to the stylesheet.
Ideally this would be handled from the block.json file, but currently styles handling is pretty limited there, so hooking in
$wp_stylesto inject the dependency was the simplest way to handle this.How has this been tested?
Tested in a block theme, by visiting a post. The template for the single posts in the FSE theme has a post-comments form, and no button.
Screenshots
Before:
After:
Checklist:
*.native.jsfiles for terms that need renaming or removal).