Fix nav screen margin. #31493
Merged
Fix nav screen margin. #31493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
CSS Styling
jasmussen
requested review from
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Size Change: +45 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
I just noticed a couple of things (probably related):
Screen.Recording.2021-05-05.at.11.18.02.movOther than that the fix works great! |
|
Thanks for the review! It was my understanding that the "Page List" block should never be used in the navigation screen, but I'm not up to date with the latest of it. But that's why I haven't touched the CSS for that one a lot. @draganescu if you have time? |
|
Without themes optin in to support blocks in navigation locations, the pages block won't appear.I think if we see by default blocks in the navigation editor it is a bug. |
|
Fixed page list too:
|
|
I'd love a ✅ here ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31454.
Before:
After:
How has this been tested?
Go to the new navigation screen and observe menu item widths are correct. Inspect a background color in, if you need to.
Checklist:
*.native.jsfiles for terms that need renaming or removal).